Fix CustomizeCode tool to return package and language#15494
Open
Fix CustomizeCode tool to return package and language#15494
Conversation
github-actions
Bot
added
the
azsdk-cli
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the azsdk_customized_code_update tool to populate PackageName, Language, PackageType, and TypeSpecProject on most response paths by resolving PackageInfo up-front and funneling returns through a shared response-enrichment helper.
Changes:
- Resolve
PackageInfoearly via the selectedLanguageService(with warning-only failure handling). - Introduce a local
CreateResponse(...)helper that fills in package/language/type metadata consistently. - Wrap most existing early-return responses with
CreateResponse(...)so metadata is present even on failures.
Comment on lines
+202
to
+206
| CustomizedCodeUpdateResponse CreateResponse(CustomizedCodeUpdateResponse response) | ||
| { | ||
| response.PackageName ??= packageInfo?.PackageName; | ||
| response.Language = packageInfo?.Language ?? languageService.Language; | ||
| response.PackageType = packageInfo?.SdkType ?? SdkType.Unknown; |
Member
Author
There was a problem hiding this comment.
@copilot apply changes based on this feedback
Contributor
There was a problem hiding this comment.
Applied in commit 1ba4648. The remainder of RunUpdateAsync (after languageService/packageInfo are resolved and CreateResponse is defined) is now wrapped in an outer try/catch that:
- Rethrows
OperationCanceledExceptionto honor cancellation - Returns
CreateResponse(...)with enriched package/language metadata for any unexpected errors from downstream operations (regen, build, second classification pass, patching, etc.)
Also fixed the GetPackageInfo catch block (the first reviewer comment) to include catch (OperationCanceledException) when (ct.IsCancellationRequested) { throw; } before the broad catch so cancellation isn't swallowed there either.
ronniegeraghty
added
the
AzSDK Tools Agent
…nder in try/catch Agent-Logs-Url: https://github.com/Azure/azure-sdk-tools/sessions/20d768ee-6217-409a-81b5-4be796043ded Co-authored-by: samvaity <16845631+samvaity@users.noreply.github.com>
Contributor
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed package_type and language is
Unknownbecause this response path never sets it